Soft deprecate webrick and add some details as to why. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
soft-deprecation-webrick
branch
2 times, most recently
from
c837e1e to
d5dc856
Compare
jeremyevans
approved these changes
Nov 2, 2024
ioquatix
force-pushed
the
soft-deprecation-webrick
branch
from
9771b55 to
d5d46c5
Compare
myronmarston
added a commit
to block/elasticgraph
that referenced
this pull request
Nov 4, 2024
Rackup 2.2 no longer depends on `webrick`, and our usage of `rackup` fails if we don't add a dependency on `webrick`. For details on the `rackup` change, see: rack/rackup#23 Note that the `rackup` maintainers recommend using `falcon` or `puma` instead of `webrick`. However, `falcon` and `puma` are heavier weight. `falcon` has lots of runtime dependencies and `puma` depends on `nio4r` which has native code. As a result, it's more likely to hit installation issues for ElasticGraph users than `webrick`. So for now we are sticking with `webrick` but I'm open to changing this in the future.
myronmarston
added a commit
to block/elasticgraph
that referenced
this pull request
Nov 4, 2024
Rackup 2.2 no longer depends on `webrick`, and our usage of `rackup` fails if we don't add a dependency on `webrick`. For details on the `rackup` change, see: rack/rackup#23 Note that the `rackup` maintainers recommend using `falcon` or `puma` instead of `webrick`. However, `falcon` and `puma` are heavier weight. `falcon` has lots of runtime dependencies and `puma` depends on `nio4r` which has native code. As a result, it's more likely to hit installation issues for ElasticGraph users than `webrick`. So for now we are sticking with `webrick` but I'm open to changing this in the future.
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Nov 7, 2024
WEBrick is not recommended for production usage, and the rackup gem dropped the dependency on it. [1], [2] With these changes in mind, just recommend Puma as the web server, for simplicity. [1]: ruby/webrick@70b026c [2]: rack/rackup#23
dentarg
added a commit
to sinatra/sinatra
that referenced
this pull request
Nov 7, 2024
WEBrick is not recommended for production usage, and the rackup gem dropped the dependency on it. [1], [2] With these changes in mind, just recommend Puma as the web server, for simplicity. [1]: ruby/webrick@70b026c [2]: rack/rackup#23
Earlopain
added a commit
to Earlopain/rackup
that referenced
this pull request
Nov 8, 2024
Followup to rack#23 Even when users do add webrick to their gemfile, the handler is not available. This means that they either need to do that themselves, or dependencies need to be updated.
|
If rackup itself is soft-deprecated, how about leaving the webrick dep in place and unwinding the compatibility snafu? Allow it to continue behaving just as it did before, and advise folks to move off Rackup instead. If Rackup does carry on, make the webrick dep change in a major release (3.0). |
|
I don’t have a strong opinion about this except that some of the things that broke already looked kind of broken to me. I don’t think we should encourage further usage of webrick either. So if we did what you suggest and users upgrade to 3, they would be in the same boat? In other words the best solution for people right now is to pin the version until downstream dependencies are fixed? Or just accelerate the deployment and release of those fixes? |
ioquatix
pushed a commit
to Earlopain/rackup
that referenced
this pull request
Nov 13, 2024
Followup to rack#23 Even when users do add webrick to their gemfile, the handler is not available. This means that they either need to do that themselves, or dependencies need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeremyevans I have copied your advice from #12 (comment) and moved
webrickto a development dependency.Fixes #12.